Fix dynamic JS import and add missing scripts for colormaps #193
Conversation
|
The new commit adds the view change detection section to the |
|
@blackary The way I hear these issues people are having, it sounds like a race condition to me. For a common dependency like d3, I wonder if we should just add it to the JS component side of the house. Though, I'm not exactly certain the browser behavior if you have a dependency specified, then specify it again dynamically like this package now does |
|
@Navxihziq Currently the tests are failing from some small type-hint and formatting issues, you please use pre-commit to fix the linting issues, or fix them manually, or allow admins to commit to your branch? |
|
@blackary Fixed! |
streamlit_folium/__init__.py
Outdated
| @@ -5,10 +5,11 @@ | |||
| import re | |||
| import warnings | |||
| from textwrap import dedent | |||
| from typing import Iterable | |||
| from typing import Iterable, List | |||
There was a problem hiding this comment.
nitpick: Because of line 1, you can just use list[str] instead of importing List
There was a problem hiding this comment.
Update committed!
This PR addresses several issues related to dynamic JavaScript packages imports and the not displayed colormap.
JavaScript package loading order
The script loading mechanism in
index.tsxhas been modified to ensure that JavaScript packages are imported sequentially. This should fix the issues with the vanishing overlay and feature groups caused by dependencies not being loaded in the correct order.Colormap display
The
d3package, required for displaying thecolormap, has been manually included. The previous dynamic JS and CSS dependency detection in__init__.pydid not work forbranca.colormap.ColorMapobjects, leading to the colormap not being displayed.With these changes, the dynamic package loading and colormap display issues should be resolved.